search

ember-template-lint / eslint-plugin-hbs

Plugin for eslint which checks inline hbs templates
ISC License
18 stars 8 forks source link

Move ember-template-lint to peerDependencies? #25

Closed rwjblue closed 4 years ago

rwjblue commented 6 years ago

eslint-plugin-hbs currently has a direct dependency on ember-template-lint, but with the upcoming release of ember-template-lint@1.0.0 having our own version as a direct dependency of eslint-plugin-hbs means that this eslint plugin cannot interoperate with either ember-template-lint@1 or ember-template-lint@0.8.

Now, we could solve this via a "standard" major version bump (keeping the direct dep), but I think perhaps a better long term solution would be to:

  1. move ember-template-lint into both peerDependencies and devDependencies
  2. lazily require ember-template-lint here and report an error if not found
  3. bump majors (it still is a "breaking" change to require the project to have the dependency I think)
  4. 💸 profit

What do you think?

rwjblue commented 5 years ago

@psbanka - What do you think?

amk221 commented 5 years ago

@psbanka hi 👋 can we get an update on this one please? thanks!

psbanka commented 5 years ago

Sorry, y'all. Yes. I've been away from this for quite a while. Will take care of this.

amk221 commented 4 years ago

Hi, just checking in - it's been 3 months. What's the plan :D

psbanka commented 4 years ago

Sorry again for the delay. I have made the changes suggested and released a new version.