search

ember-template-lint / eslint-plugin-hbs

Plugin for eslint which checks inline hbs templates
ISC License
18 stars 8 forks source link

Fix linter invocation by removing the need to async #52

Closed NullVoxPopuli closed 2 years ago

NullVoxPopuli commented 2 years ago

Update

Tested this locally in my project and got this: image

the approach here is kind of hacky... but I don't currently see a way around the problem until eslint supports async tree-walker stuff

This is no longer valid: but I'm keeping the text for thought process / what the alternative to node-force-sync would be

I tested this locally by editing node_modules, and it works.

I say "works" in that I verified with that the issue reported: https://github.com/ember-template-lint/eslint-plugin-hbs/issues/51 is resolved. (tested with console.log).

However, I do not get eslint reporter results (yet). Looks like this is the reason: https://github.com/ember-template-lint/eslint-plugin-hbs/issues/42#issuecomment-794638754

So, we need verifySync in ember-template-lint, related issue: https://github.com/ember-template-lint/ember-template-lint/issues/1838

TODOs

NullVoxPopuli commented 2 years ago

superseded by ember-template-lint reading in js/ts/gjs/gts per: https://github.com/ember-template-lint/ember-template-lint/pull/2483