Pass filePath option to linter.verify

[jgwhite]

I found that ember-language-server (via the vscode extension) seemed to be ignoring my overrides configuration. Digging into it, it seems like ember-template-lint wants not only moduleId but also filePath in order for overrides to behave correctly. I’m not quite sure why this is but I’ve asked right here: https://github.com/ember-template-lint/ember-template-lint/issues/1346

[lifeart]

Hi @jgwhite! Thank you for report! This language server in maintance mode, try https://github.com/lifeart/ember-language-server https://marketplace.visualstudio.com/items?itemName=lifeart.vscode-ember-unstable

https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/src/template-linter.ts#L70

[jgwhite]

@lifeart ah ok — should I make the same PR to the unstable language server?

What’s the plan moving forward? Will unstable take over the NPM package name? What will happen with the two VSCode extensions?

[lifeart]

@jgwhite I think it should work in UELS, if not - PR's - are welcome :)

Will unstable take over the NPM package name? - nope. What will happen with the two VSCode extensions? - you need to remove "Ember Language Server" and install only "Unstable Language Server".

If you interested in language server addons - see https://github.com/lifeart/ember-language-server/issues/12

[jgwhite]

you need to remove "Ember Language Server" and install only "Unstable Language Server".

Is this documented anywhere? The readme for the stable language server VSCode extension doesn’t seem to mention it.

Will you continue to call the project/extension “unstable ember language server”? Or will it become “stable” at some point?

[jgwhite]

I guess my broader question is: Why fork the project? Why not bring all the good stuff from unstable ember language server into this project?

[lifeart]

There is no capacity to review and split down to features https://github.com/ember-tooling/ember-language-server/pull/173

[lifeart]

Will you continue to call the project/extension “unstable ember language server” - yes, and it’s stable, but has a lot of experimental features.

[lifeart]

See https://github.com/emberjs/core-notes/blob/726a36aa32c796b8d7e4592bbe62e08ec46fc619/ember.js/2019-11/Nov%2022%202019.md for official concerns

[jgwhite]

@lifeart thanks for all the details — I think I understand the state-of-play now.

I checked and UELS does exhibit the same issue with ember-template-lint and overrides. Opened https://github.com/lifeart/ember-language-server/pull/109 to rectify.

Is it possible to ship a new version of the stable ELS with this fix?

[lifeart]

@jgwhite issue fixed in https://github.com/lifeart/ember-language-server/pull/72 (for has different base) New version of ELS - I don't think so, but @locks may clarify.