search

ember-tooling / ember-language-server

Language Server Protocol implementation for Ember.js projects
MIT License
98 stars 39 forks source link

Prepare for big merge #386

Closed evoactivity closed 7 months ago

evoactivity commented 7 months ago

Preparing for the big merge as discussed in #385

I've removed everything except the LICENSE.md so we don't remove original authors coyright. @lifeart can you solve the conflict by adding yourself to the list when creating your PR

evoactivity commented 7 months ago

Before I click the button does anyone see any issues with doing this?

@nullvoxpopuli @matchy @locks

lifeart commented 7 months ago

@evoactivity yep

evoactivity commented 7 months ago

I've created an ember-tooling organisation on npm, I've invited @nullvoxpopuli and @lifeart to that organisation.

@lifeart we'll need to update the workflow so it publishes to that npm organisation

If there are others who should have access let me know.

evoactivity commented 7 months ago

@lifeart is there a reason this https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/.github/workflows/ci.yml#L131 doesn't use the standard secret.GITHUB_TOKEN ?

lifeart commented 7 months ago

@evoactivity I think it's legacy from https://github.com/lifeart/ember-language-server/commit/81728b6b77e9dc005e4e5253fb24e6eb1ac2bc22

locks commented 7 months ago

Before I click the button does anyone see any issues with doing this?

@nullvoxpopuli @matchy @locks

you're the boss!

NullVoxPopuli commented 7 months ago

image

if only every PR could be like this :sweat_smile: