search

ember-tooling / ember-language-server

Language Server Protocol implementation for Ember.js projects
MIT License
98 stars 39 forks source link

Support all template-lint extensions #400

Closed NullVoxPopuli closed 4 months ago

NullVoxPopuli commented 4 months ago

ember-template-lint support mjs, so we should key off that, when possible -- I also added cjs because it's spiritually equiv to js in v1 apps right now.

Without this change, we can see ember-template-lint working in the terminal, but not in editors.

NullVoxPopuli commented 4 months ago

how should this be tested? :thinking: (I'm new here)

lifeart commented 4 months ago

@NullVoxPopuli testing same as debugging - https://github.com/ember-tooling/vscode-ember/blob/master/DEBUGGING.md In short, we need to bundle LS and check how it's works in VSCode extension (or other env's)

NullVoxPopuli commented 4 months ago

Run debugger Client + Server

what is this step?

NullVoxPopuli commented 4 months ago

I think something may have been lost in the repo move, perhaps -- there is no Launch Client :sweat_smile:

lifeart commented 4 months ago

@NullVoxPopuli click on BUG + PLAY icon and select "Client + Server" preset

image
lifeart commented 4 months ago

@NullVoxPopuli configs for debugging located here: https://github.com/ember-tooling/vscode-ember/blob/master/.vscode/launch.json#L35

NullVoxPopuli commented 4 months ago

hm, why isn't my breakpoint bound?

image

lifeart commented 4 months ago

Looks like debugger not connected to LS, or LS not running (try do some code action to initialise LS)

NullVoxPopuli commented 4 months ago

I think I can confirm this works image

still struggling with getting any breakpoint to hit tho :sweat_smile:

I want to try Promise.race

lifeart commented 4 months ago

@NullVoxPopuli thank you for contribution, fix should be available in VScode - https://github.com/ember-tooling/vscode-ember/releases/tag/v3.0.57