comments without `--` are not identified as comments when multiline.

ember-tooling / tree-sitter-glimmer

A TreeSitter grammar for Glimmer (HBS) templates

https://ember-tooling.github.io/tree-sitter-glimmer/

24 stars 3 forks source link

comments without `--` are not identified as comments when multiline. #100

Closed NullVoxPopuli closed 11 months ago

NullVoxPopuli commented 1 year ago

Test:

<div
  {{! 
    this is a 
    multi-line comment
  }}
>

alexlafroscia commented 12 months ago

Is this format of comment supposed to be valid syntax? As far as I know, multi-line comments need the -- after the ! but it's very possible that's changed; it's been a long time since I was up-to-date on Ember-related stuff.

NullVoxPopuli commented 12 months ago

It is valid, yeah, for example: https://limber.glimdown.com/edit?c=MQAgwg9gtlCmB2AXAzgKFQC0YgDsgXAPSEDmAlohgK4BGAdAMbSECGANrAB5ssBmAThGQMyLQon6xYAWmQVEsftJJsyMRYTLJkVWMkIBGAAxH0AAwskAVshCqAbrFQAeBVBw8FAPlQgQAFS5EXxAAb1CAQmlpEAAZCHgScGg4JBBogF8MkPCo6RC-ECgqNkQyVXhYOwSkpnU0kMzsv1zogr9i0vKySurEkDrUxBB2kHY2CAB3W3CQLJBJigwexukskMDOYJbIkGQMCH5hwYRh9Z2IkcKikrKKqv3D45TTkPOAoJDnPJAsKDYBi80tEfH5vm1rp07j0qn8ASckKsfM5xLB3J5YD4LGZUEA&format=glimdown

alexlafroscia commented 12 months ago

I see! Good to know!

NullVoxPopuli commented 11 months ago

This is resolved!