search

ember-tooling / vscode-ember

VSCode client for the Ember Language Server
https://marketplace.visualstudio.com/items?itemName=emberjs.vscode-ember
Other
48 stars 18 forks source link

Change to glob pattern to support monorepos #9

Closed chrisvdp closed 5 years ago

chrisvdp commented 5 years ago

fixes #7

lifeart commented 5 years ago

@chrisvdp can you plz add ignores +limitations into this PR? https://github.com/lifeart/vscode-ember/blob/master/src/extension.ts#L43

chrisvdp commented 5 years ago

done

lifeart commented 5 years ago

@Turbo87 could you plz merge this PR and create new ext version?

Turbo87 commented 5 years ago

@lifeart where can I find docs on those additional parameters? I seem to have a hard time finding any API documentation for the vscode package 🤔

lifeart commented 5 years ago

@Turbo87 https://code.visualstudio.com/api/references/vscode-api#workspace

image

danwenzel commented 5 years ago

Thank you for this fix! @Turbo87 - when will this be released to a new version?

lifeart commented 5 years ago

@danwenzel try https://marketplace.visualstudio.com/items?itemName=lifeart.vscode-ember-unstable As I know, there is some problems with creds for official ember account for Microsoft VSC store, @locks on it

danwenzel commented 5 years ago

Thank you, @lifeart ! That worked