search

emberjs / babel-plugin-ember-template-compilation

Babel implementation of Ember's low-level template-compilation API
9 stars 11 forks source link

fix: @babel/traverse is a dependency not a dev-dependency #24

Closed runspired closed 1 year ago

runspired commented 1 year ago

I think this is what is needed to resolve #23. Not able to test this via pnpm patch as apparently package.json dependencies can't be fixed that way. Setting pnpm up like the following which mirrors this change did work:

 "packageExtensions": {
      "babel-plugin-ember-template-compilation": {
        "dependencies": {
          "@babel/traverse": "^7.14.5"
        }
      }
ef4 commented 1 year ago

Thanks. This got missed because it was originally only used for type imports, but then we added one real implementation import.

ef4 commented 1 year ago

Followed up with https://github.com/emberjs/babel-plugin-ember-template-compilation/pull/25 because we never should have depended directly on traverse in the first place.