search

emberjs / data

A lightweight reactive data library for web applications. Designed over composable primitives.
https://api.emberjs.com/ember-data/release
Other
3.03k stars 1.33k forks source link

CI Failing for Canary Ember #6253

Closed rwjblue closed 5 years ago

rwjblue commented 5 years ago

CI is currently failing against Canary versions of ember-source (indicating “test is not isolated”).

I haven’t done much digging but I suspect the change that is causing the issue is Ember’s new auto-tracking (the feature was enabled just a couple days ago).

Making this as a placeholder for working through the issues (though it may need fixes in Ember and/or ember-qunit).

rwjblue commented 5 years ago

I believe that https://github.com/emberjs/ember-qunit/pull/478 is related (and that @pzuraq worked on it because of these failures in ED’s test suite while he was working on the feature).

runspired commented 5 years ago

There seem to be new canary features unrelated to why this was originally opened: roughly the issue is that some properties for observers are now computeds that we can't access during the destroy lifecycle

runspired commented 5 years ago

cc @pzuraq

rwjblue commented 5 years ago

We need to update to https://github.com/emberjs/ember-qunit/releases/tag/v4.5.1 to get the fixes for waiting on the trailing auto-run.

HeroicEric commented 5 years ago

Here is the related issue mentioned above related to observers https://github.com/emberjs/ember.js/issues/18225