emberjs / ember-cli-babel

Ember CLI plugin for Babel
MIT License
153 stars 120 forks source link

Package no longer installs on Node 6/8 #326

Closed Turbo87 closed 4 years ago

Turbo87 commented 4 years ago

babel-plugin-ember-data-packages-polyfill specifies 10.* || >= 12.* as its Node support, which is incompatible with ember-cli-babel still supporting Node 6 and 8.

/cc @rwjblue @runspired

Turbo87 commented 4 years ago

Example CI failures:

rwjblue commented 4 years ago

Hmm, ember-cli-babel's own CI passes on Node 6 šŸ¤”

rwjblue commented 4 years ago

(I confirmed that it was running properly before merging)

Turbo87 commented 4 years ago

yep, but it's using --ignore-engines šŸ˜ž

sandydoo commented 4 years ago

Also the ember-cli default for both apps and addons is "node": "8.* || >= 10.*" and the node version for travis is also set to 8, so it's easy to stumble on this just by religiously upgrading with ember-cli-update.

xg-wang commented 4 years ago

I'm seeing same error, does babel-plugin-ember-data-packages-polyfill only work on node 10+?

runspired commented 4 years ago

@xg-wang it should work with more versions than that although the tests may not. The issue is it declares a version in engines that although is the correct version for what we support in the ember ecosystem at the point it was released is not what ember-cli-Babel currently has.

Iā€™m going to see about cutting a version that ensures support for these legacy versions but we should also bump ember-cli-Babel soon

runspired commented 4 years ago

https://github.com/ember-data/babel-plugin-ember-data-packages-polyfill/pull/4 will resolve this for the plugin