emberjs / ember-cli-babel

Ember CLI plugin for Babel
MIT License
153 stars 119 forks source link

Upgrading from 7.23.1 to 7.24.0 made the cached-decorator-polyfill not able to work? #383

Closed NullVoxPopuli closed 1 year ago

NullVoxPopuli commented 3 years ago

The Error I got:

Build Error (broccoli-persistent-filter:Babel > [Babel: pinochle]) in pinochle/components/hand/index.ts

emberclear/client/web/pinochle/pinochle/components/hand/index.ts: @glimmer/tracking does not have a cached export
  2 | const __COLOCATED_TEMPLATE__ = hbs("template-stuff","moduleName":"pinochle/components/hand/index.hbs","parseOptions":{"srcName":"pinochle/components/hand/index.hbs"}});
  3 | import Component from '@glimmer/component';
> 4 | import { cached } from '@glimmer/tracking';
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  5 | import { getOwner } from '@ember/application';
  6 | import { action } from '@ember/object';
  7 | 

Stack Trace and Error Report: /tmp/error.dump.49678f9e0a563674b73d06e32e7bc91f.log
rwjblue commented 3 years ago

The way that works at the moment is just brittle. Now that cached decorator RFC is landed, we should add an export to ember-rfc176-data. That would fix this error, and make it work more naturally.

bertdeblock commented 1 year ago

@NullVoxPopuli Going to close this, as I think this has been fixed by https://github.com/ember-cli/ember-rfc176-data/pull/322. Please reopen if I'm mistaken!