search

emberjs / ember-cli-babel

Ember CLI plugin for Babel
MIT License
153 stars 119 forks source link

Class decorator woes with 7.26.7 #423

Closed jherdman closed 2 years ago

jherdman commented 2 years ago

Since updating to ecli-babel 7.26.7 I see the following error:

Decorating class property failed. Please ensure that proposal-class-properties is enabled and runs after the decorators transform

This is reproduced with the following app: https://github.com/jherdman/hump-day-sadness

Edit: updated the version number 🤭

vst commented 2 years ago

Same here. ~I had to pin down the dependency to v7.26.6.~

PS: I think that you meant v7.26.7.

Update: Pinning to v7.26.6 did not work in our application. v7.26.7 gets installed too somehow when regenerating yarn.lock (weird), and in return, this breaks the application.

NullVoxPopuli commented 2 years ago

Whoops, i made a duplicate https://github.com/babel/ember-cli-babel/issues/425

dknutsen commented 2 years ago

@vst you can use a yarn resolution to force 7.26.6 temporarily

chriskrycho commented 2 years ago

Working on a fix in #426. Will update there as we make progress. (Turns out we didn't have test coverage for this! That's the first thing I'm doing: adding coverage.)