search

emberjs / ember-cli-babel

Ember CLI plugin for Babel
MIT License
153 stars 119 forks source link

Babel polyfill broken in 7.26.10 #429

Closed nickschot closed 2 years ago

nickschot commented 2 years ago

Specifying 

  // ember-cli-build.js
  let app = new EmberApp(defaults, {
    'ember-cli-babel': {
      includePolyfill: true,
    },
  });

will cause the following error on build:

Build Error (SourceMapConcat)

ENOENT: no such file or directory, open '/var/folders/7h/82hn6hyn1bngg96_xvhlmq040000gn/T/broccoli-34311LQfVtgUc1OgD/out-262-broccoli_debug_debug_5_vendor_js/vendor/babel-polyfill/polyfill.js'

Minimal reproduction: https://github.com/nickschot/babel-polyfill-repro

Adonis320 commented 2 years ago

Affects versions 7.26.7 and upwards

rwjblue commented 2 years ago

Hmph. Why? This is strange, we didn't change anything RE: the polyfill in these versions 🤔

nickschot commented 2 years ago

Good question 😂 I ran into it testing the updated version to see if my private class property issues were resolved.

chriskrycho commented 2 years ago

I suspect it was an “unclean revert”[^1]: ea752c4 reverted 0d47e8b, but did not revert the bump to @babel/preset-env that was included there. Presumably there’s a difference in what the updated @babel/preset-env is requiring or not for the polyfill.

[^1]: this sounds hilarious 😂

rwjblue commented 2 years ago

Sorry about this y'all, fixed in https://github.com/babel/ember-cli-babel/releases/tag/v7.26.11