search

emberjs / ember-cli-babel

Ember CLI plugin for Babel
MIT License
153 stars 119 forks source link

Fix missing babel polyfill in vendor tree #430

Closed jaswilli closed 2 years ago

jaswilli commented 2 years ago

I believe this is a fix for the mystery of the missing babel polyfill as reported in #429. It seems as though the culprit was the introduction of cacheKeyForTree() in #421.

Since our treeForVendor() conditionally adds in the babel polyfill we need to consider that condition when generating the cache key for vendor.

I verified this fixes the simple reproduction (new Ember app with the polyfill enabled in ember-cli-build) and it also fixes this same issue on a big app I have at work.

This is the first time I've gone under the covers of ember-cli-babel so I'm happy to be educated if there's a better strategy for fixing this.

EstesE commented 2 years ago

Thanks, this worked for me.

jamescdavis commented 2 years ago

This fixes things for me as well. #421 was definitely the breaking change. @rwjblue, can we push this through?

rwjblue commented 2 years ago

Sorry for slow response here y'all, thank you @jaswilli for workin' up a fix!!