search

emberjs / ember-cli-babel

Ember CLI plugin for Babel
MIT License
153 stars 119 forks source link

Allow passing in generatorOpts #468

Closed colenso closed 1 year ago

colenso commented 1 year ago

Allows passing in generatorOpts to babel https://babeljs.io/docs/en/options#generatoropts without passing it to preset-env. This will allow passing options like compact etc to babel. Did this as referenced in https://github.com/ef4/ember-auto-import/issues/549#issuecomment-1330104695

ef4 commented 1 year ago

Thanks, this looks good to me. Not having it is definitely a gap, and telling people to switch to useBabelConfig: true (as mentioned in other issues about this) without creating an upgrade path for their addon-provided babel plugins isn't really a viable alternative at this time.

ef4 commented 1 year ago

The 8.0.0 release is imminent, so this will be in there. I don't think 8.0 will be a difficult upgrade for most people, but if it turns out to be we can also consider back-porting this.

colenso commented 1 year ago

Awesome! Thanks