search

emberjs / ember-cli-babel

Ember CLI plugin for Babel
MIT License
153 stars 120 forks source link

fix: filter undefined options #500

Closed runspired closed 1 year ago

runspired commented 1 year ago

resolves #499

PR with a patch demonstrating this fix for EmberData https://github.com/emberjs/data/pull/8800

runspired commented 1 year ago

looks like there was a dependency installation timeout on the two failing scenarios and they just need a kick.

NullVoxPopuli commented 1 year ago

Any chance you'd be willing to add a test for this? in particular, around here: https://github.com/babel/ember-cli-babel/blob/master/node-tests/addon-test.js#L1689

I did a search for babel: in the tests, and found few -- but all had options specified, so the undefined config scenario isn't covered