emberjs / ember-inspector

Adds an Ember tab to the browser's Developer Tools that allows you to inspect Ember objects in your application.
MIT License
966 stars 286 forks source link

add release plan #2563

Closed patricklx closed 7 months ago

patricklx commented 8 months ago

i think it would be nice to have release-plan here as well

patricklx commented 8 months ago

@NullVoxPopuli can you have a look if this setup is correct? especiially because we have scheduled release as well (nightly) to npm as well. Does pnpm release-plan also create a github tag & release. and is it disabled of tag=alpha ?

RobbieTheWagner commented 8 months ago

We cannot do automated releases because releasing to the Chrome store doesn't work. We need to find a way to get a new token or whatever for that.

patricklx commented 8 months ago

But we are already doing it. This just gives a nice preview PR that can be merged to trigger the publishing. You probably need to get a new refresh token?

patricklx commented 8 months ago

Found this: https://github.com/PlasmoHQ/chrome-webstore-api/blob/main/token.md

Apparently it should be possible to use the same refresh token and client ID for multiple extensions. We can try using the refresh token from the nightly extension. That one is working

patricklx commented 8 months ago

Another thing i found: Looks like refresh token expire after 60days of no usage. One more reason to use the same as nightly.

Or just do a custom token fetch : https://dev.to/cardinalby/dont-let-google-refresh-token-expire-pie

patricklx commented 8 months ago

@RobbieTheWagner i updated the publishing to use the same token as nightly

RobbieTheWagner commented 8 months ago

@RobbieTheWagner i updated the publishing to use the same token as nightly

You are sure that is okay? I am not sure why we had separate ones before.

patricklx commented 8 months ago

@RobbieTheWagner i updated the publishing to use the same token as nightly

You are sure that is okay? I am not sure why we had separate ones before.

Not really:) but probably if they are under the same account. Worst case is that publishing will fail and you have to do it manually

NullVoxPopuli commented 8 months ago

can you have a look if this setup is correct?

I'm nervous about non-boilerplate versions of the workflows :sweat_smile: One of the things I like about release-plan is that I (for the most part) don't need to think about what's going in to the workflows -- there's been one exception so far, but the change was small.

Personally, I think we should keep extension publishing separate, but have it run on the condition that the publish.yml (to npm) has completed successfully -- that way we can still manage our custom stuff separately from the boilerplate (which should be more easily replaceable via npx create-release-plan-setup@latest --update)

patricklx commented 8 months ago

I changed the flow to let release plan make the publishing & tag & release. With minimal changes after it created the github tag, build.yml will be triggered.

patricklx commented 8 months ago

this is ready now @RobbieTheWagner

RobbieTheWagner commented 8 months ago

@NullVoxPopuli does this seem correct to you? I am not super familiar with release-plan, but would love to introduce it here.

NullVoxPopuli commented 8 months ago

yeah, as long as its known that the firefox/chrome extensions still need manual publishing

patricklx commented 8 months ago

yeah, as long as its known that the firefox/chrome extensions still need manual publishing

the release-it will create a tag which then triggers the firefox/chrome publishing