search

emberjs / ember-inspector

Adds an Ember tab to the browser's Developer Tools that allows you to inspect Ember objects in your application.
MIT License
966 stars 286 forks source link

For ember-source 5.10-beta+, do not use the Ember barrel file (it's been deprecated) #2572

Open NullVoxPopuli opened 6 months ago

NullVoxPopuli commented 6 months ago

Description

RFC: https://github.com/emberjs/rfcs/pull/1003 Implementation: https://github.com/emberjs/ember.js/pull/20686 Advancement: https://github.com/emberjs/rfcs/pull/1015 Deprecation Guide: https://github.com/ember-learn/deprecation-app/pull/1381

Screenshots

patricklx commented 6 months ago

the only parts that need changes is in ember_debug

patricklx commented 6 months ago

But is the boot event 'Ember' still dispatched? It was part of ember/index and inspector depends on it

NullVoxPopuli commented 6 months ago

all of 'Ember' is deprecated -- so my plan here is to import from -internal apis mostly, or other public apis where available

RobbieTheWagner commented 6 months ago

Is this why canary tests are failing? Wondering what fixes we need there.