search

emberjs / ember-inspector

Adds an Ember tab to the browser's Developer Tools that allows you to inspect Ember objects in your application.
MIT License
966 stars 286 forks source link

Unable to update boolean config bit #2594

Closed jessicashaver closed 4 months ago

jessicashaver commented 4 months ago

Describe the bug Ember inspector updated to version 4.13. Since the update, unable to update any boolean value.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Components'
  2. Click on 'application route'
  3. Select 'config'
  4. Search for property that's a bool that you want to change
  5. Click into value to edit

Expected behavior Clicking the bool for the config you want to change opens the field. You can switch the value to be true or false.

Actual behavior Clicking the bool for the config you want to change only highlights the bool value. User can go to Console and change the config value there using Ember.set(config, 'valueOne', false)

Environment Ember version 4.13 Chrome Version 127.0.6533.73

patricklx commented 4 months ago

I guess we need to add type-boolean here: https://github.com/emberjs/ember-inspector/blob/e17d105c3196c5e954ade15cf2f4b797bde52b98/app/components/object-inspector/property.ts#L125

RobbieTheWagner commented 4 months ago

@patricklx sounds like we need more test coverage here as well.