Open elwayman02 opened 3 years ago
Following up on discussion with @chancancode to capture some pieces we figured out:
ember-optional-features
, which was intended to be used by app consumersConclusion: It may be better for this codemod to live as a separate project in ember-codemods
rather than as part of this project.
Coming full circle on this.
@rwjblue implemented the codemod to fix this here: https://github.com/rwjblue/ember-holy-futuristic-template-namespacing-batman-codemod/pull/58
However, there is a related issue that I believe does impact this project. If you enable template-only-glimmer-components
in an addon, it does not create backing classes for template-only components in tests/dummy/templates/components
, which is a perfectly valid use-case for addons.
which is a perfectly valid use-case for addons
Ya, agreed.
It appears that the codemod implementation only runs against components in the
app/
directory, which will not work for addons, which store their components in theaddon/
directory and may not re-export them at all (since doing so is dangerous and a bad pattern). In order for addons to successfully enable this feature, the codemod needs to be able to create backing classes for addon components.https://github.com/emberjs/ember-optional-features/blob/master/features/template-only-glimmer-components.js#L55