search

emberjs / ember-qunit

QUnit test helpers for Ember
Other
259 stars 154 forks source link

The "Disable Linting" checkbox does nothing #1139

Open nelstrom opened 1 year ago

nelstrom commented 1 year ago

In the test runner, we have a "Disable Linting" checkbox:

qunit-nolint

After creating a brand new Ember app (via ember new), I noticed that the "Disable Linting" checkbox has no effect. Whether it's checked or unchecked, linting doesn't happen inside the test runner.

NullVoxPopuli commented 1 year ago

I think the checkbox only ever did anything if you had ember-cli-eslint or ember-cli-template-lint -- do you have either of those?

If not, we should probs find a way to remove that checkbox!

Thanks for reporting!

nelstrom commented 1 year ago

Ah right! ember-cli-eslint and ember-cli-template-lint are both marked as deprecated.

As I see it, there's two ways of doing this. Either:

  1. Remove the "Disable Linting" checkbox, and strip out any dead code that handles that functionality
  2. OR remove the checkbox, but leave the code that implements that functionality, and add some documentation somewhere on how to add the checkbox back for anyone that misses it

Either way, I think the checkbox needs to go. It's squatting on some valuable real-estate.

I've had a go at removing the checkbox in #1140.