search

emberjs / ember-qunit

QUnit test helpers for Ember
Other
259 stars 154 forks source link

nocontainer param no longer hides the container #923

Open runspired opened 2 years ago

runspired commented 2 years ago

regardless of checkbox state the container is shown.

runspired commented 2 years ago

just coming back to this to see if anyone has looked into why? it's been broken almost 2 years.

runspired commented 2 years ago

The answer is that these lines: https://github.com/emberjs/ember-qunit/blob/472036008c90a8a504907626460a20601a8be82d/addon-test-support/index.js#L86-L89

run before the DOM is fully constructed.

in my test's index.html I needed to move 

    <div id="qunit"></div>
    <div id="qunit-fixture">
      <div id="ember-testing-container">
        <div id="ember-testing"></div>
      </div>
    </div>

above 

    <script src="/testem.js" integrity=""></script>
    <script src="{{rootURL}}assets/vendor.js"></script>
    <script src="{{rootURL}}assets/test-support.js"></script>

    <script src="{{rootURL}}assets/dummy.js"></script>
    <script src="{{rootURL}}assets/tests.js"></script>

This is a funny "gotya" because everything about the tests continues to work as normal except this one feature. I suspect that feature should be made to grab the html element lazily.