search

emberjs / ember-render-modifiers

Implements did-insert / did-update / will-destroy modifiers for emberjs/rfcs#415
MIT License
86 stars 33 forks source link

Uses version of modifier manager capabilities that is deprecated in canary #32

Closed wagenet closed 2 years ago

wagenet commented 3 years ago 
Versions of modifier manager capabilities prior to 3.22 have been deprecated. You must update to the 3.22 capabilities.
boris-petrov commented 3 years ago

Isn't the underlying issue in ember-modifier?

alexlafroscia commented 3 years ago

I don't think that's the case here @boris-petrov -- this package does not depend on that one.

This addon creates a modifier manager itself

https://github.com/emberjs/ember-render-modifiers/blob/ec0a84cd191dfa628d933686c781e64c5223823f/addon/modifiers/did-insert.js#L49

jgadbois commented 3 years ago

I'm getting deprecation warnings in Ember 3.26

alexlafroscia commented 3 years ago

33 should resolve this once it's merged

martinbarilik commented 3 years ago

@alexlafroscia when it's gonna be ? :)

alexlafroscia commented 3 years ago

No idea 🤷‍♂️any context about that would be on the PR that I linked to, and that doesn't have an update within the last week.

SergeAstapov commented 3 years ago

42 was merged which superseded #33, now new release should be cut and published.

sandstrom commented 3 years ago

awesome @SergeAstapov 🎉

SergeAstapov commented 3 years ago

@wagenet this has been fixed and released in v2.0.0 🎉!

acorncom commented 2 years ago

Looks like this can be closed