search

emberjs / ember-render-modifiers

Implements did-insert / did-update / will-destroy modifiers for emberjs/rfcs#415
MIT License
86 stars 33 forks source link

Update manager capabilities to 3.22 to fix deprecation in Ember 3.26+ #42

Closed SergeAstapov closed 3 years ago

SergeAstapov commented 3 years ago

This takes over #33.

Note that release/beta/canary fail in master hence CI is not completely happy.

Created same PR in my fork to check CI and all tests pass (except release/beta/canary): https://github.com/SergeAstapov/ember-render-modifiers/pull/5/checks

In order to get release/beta pass, we need to land #40 by @kiwiupover first. Created such PR in my fork to check CI and all tests pass except canary: https://github.com/SergeAstapov/ember-render-modifiers/pull/3/checks?check_run_id=3748714875

The issue we get on canary is

Error: To use these addons, your app needs ember-auto-import >= 2: ember-source
RobbieTheWagner commented 3 years ago

@SergeAstapov I merged #40. Can you please rebase your PR?

SergeAstapov commented 3 years ago

@rwwagner90 Thank you! Rebased onto latest master

patrickberkeley commented 3 years ago

@rwwagner90 will you cut a release for this please?

RobbieTheWagner commented 3 years ago

@patrickberkeley I don't think I have permissions to cut releases.

acorncom commented 2 years ago

Release was cut Oct 6 for folks following along on this PR