search

emberjs / ember-test-helpers

Test-framework-agnostic helpers for testing Ember.js applications
Apache License 2.0
187 stars 257 forks source link

Conflicting rule in `"resolutions"` in root `package.json` and addon's `package.json` for `rimraf` causing failure. #1463

Closed shubham88fru closed 3 months ago

shubham88fru commented 3 months ago

Hi,

I cloned the master branch and tried doing yarn install and then yarn test but seeing the following error -

Screenshot 2024-07-22 at 2 58 08 PM

This seems to be happening because the addon required rimraf version ^5.0.1 - https://github.com/emberjs/ember-test-helpers/blob/3b83f12656ab9443603da79575ab8a744d56fcb9/addon/package.json#L104

but the "resolutions" in the root package.json restricts rimraf version to < 5.0.0 - https://github.com/emberjs/ember-test-helpers/blob/3b83f12656ab9443603da79575ab8a744d56fcb9/package.json#L17

because of this, on doing yarn install a lower version of rimraf (version 4.x) is installed, than what is need for the addon module (version 5.x) -

Screenshot 2024-07-22 at 3 04 32 PM

I tried removing the rimraf entry from "resolutions" altogether and was able to run the tests.

Please let me know your thoughts on this. Should I create a PR for this?

NullVoxPopuli commented 3 months ago

This is solved by this PR: https://github.com/emberjs/ember-test-helpers/pull/1453 waiting for review over there.

shubham88fru commented 3 months ago

Closing this issue since PR #1453 has been merged.