search

emberjs / ember-test-waiters

An Ember addon to allow @ember/test-helpers to manage asynchronous operations
MIT License
29 stars 15 forks source link

Drop support for Typescript < 4.9 #474

Closed NullVoxPopuli closed 4 months ago

NullVoxPopuli commented 4 months ago

We want to use ember-source's built in types for internal type checking, and we can't do that with TS < v4.9

TS v4.9 was released November of 2022

kategengler commented 4 months ago

Ember itself still supports 4.9 https://github.com/emberjs/ember.js/blob/main/.github/workflows/ci.yml#L57

NullVoxPopuli commented 4 months ago

legit, still way better than 4.4 I'll update

kategengler commented 4 months ago

If you follow TS Semver, like Ember, a change in TS versions doesn't need to be breaking iirc https://www.semver-ts.org/