search

emberjs / ember.js

Ember.js - A JavaScript framework for creating ambitious web applications
https://emberjs.com
MIT License
22.47k stars 4.21k forks source link

`link-to` `current-when` attribute does not accept a true value #16142

Closed Skwai closed 6 years ago

Skwai commented 6 years ago

Running Ember 3.0.0-beta.1

The following does not work, despite the documentation stating that I can pass a true to the current-when attribute.

{{#link-to "foo.bar" current-when=true}}Foo Bar{{/link-to}}
MaxFlower commented 6 years ago

I find description in packages/ember-glimmer/lib/components/link-to.ts: on line 537: let currentWhen = get(this, 'current-when');

next line is if (typeof currentWhen === 'boolean') { return currentWhen; } and I assume that something wrong with type which was returned by getter.

bekzod commented 6 years ago

updated current-when boolean test https://github.com/emberjs/ember.js/pull/16167 it is passing

Serabe commented 6 years ago

@Skwai we cannot reproduce this issue, can you please provide one?

Serabe commented 6 years ago

@Skwai ping.

Serabe commented 6 years ago

Closing this according to our triage policy. Please, provide a reproduction so we can follow up on this.

Thank you!