search

emberjs / ember.js

Ember.js - A JavaScript framework for creating ambitious web applications
https://emberjs.com
MIT License
22.47k stars 4.21k forks source link

Operand over 16-bits. Got 72000. #16269

Closed Turbo87 closed 6 years ago

Turbo87 commented 6 years ago

Using the latest 3.1 beta version I'm seeing an error "Operand over 16-bits. Got 72000." in one of our tests which does this:

render(hbs`{{some-component foo=9000}}`);

It seems that the maximum value for literal numbers has decreased significantly in the 3.1-beta 🤔

https://github.com/emberjs/ember.js/issues/15635 might also be related to this.

rwjblue commented 6 years ago

FWIW - This is ultimately a glimmer-vm issue...

Turbo87 commented 6 years ago

Still needs release and update here, right?

rwjblue commented 6 years ago

Yes, I didn’t close this intentionally...

rwjblue commented 6 years ago

Fixed by https://github.com/emberjs/ember.js/pull/16286

jdurand commented 6 years ago

I opened an issue https://github.com/cibernox/ember-ast-helpers/issues/23 but I'm going to log this here just in case this is a regression.

I started having these issues when I upgraded my app to ember-source@3.3.2 (and ember-data@3.4.0 mentioning because from the little I could understand one side effect could be broken hasMany relationships)

Here's a production stack trace: https://sentry.io/share/issue/b3223fa152b04552bf19ab519fcd2218/

I haven't seen this error yet for users that I rolled back to ember-source@3.1.4 & ember-data@3.1.2. I'll report back if I see something else.

jdurand commented 6 years ago

I just upgraded my app to ember-source@3.5.0 ember-data@3.5.0 and am running (I believe) glimmer@0.35.10 and I'm still getting this issue :

https://sentry.io/share/issue/0476b177707347dabbf01aef1296c957/

I'm using ember-font-awesome which relies on ember-ast-helpers. The former relied on ember-ast-helpers@0.3.5 which had a hard dependency on glimmer@0.27.0, so I forked it to loosen that dependency (diff). That's what I'm running in production along with @glimmer/compiler@0.35.10 & @glimmer/syntax@0.35.10 specified in my package.json.

I know that ember (glimmer) pre-compiles the templates so the issue has to be around the BuildTimeComponents. Did #16286 fix this use case?

I'll keep digging but, any help or hint would be very much appreciated.

jdurand commented 6 years ago

Rolled back to ember-source@3.1.4 (without touching anything else) this morning and the error stopped popping up in my logs.