search

emberjs / ember.js

Ember.js - A JavaScript framework for creating ambitious web applications
https://emberjs.com
MIT License
22.47k stars 4.21k forks source link

Tracking Issue for RFC #435 (forwarding modifiers via splattributes) #17493

Closed chancancode closed 5 years ago

chancancode commented 5 years ago

https://github.com/emberjs/rfcs/blob/master/text/0435-modifier-splattributes.md

rwjblue commented 5 years ago

Yes, IMHO this is just a bug that we should fix.

rwjblue commented 5 years ago

Specifically, I believe that we need to remove this:

https://github.com/glimmerjs/glimmer-vm/blob/11033eb39331e42068b9e7f35c19764ceb1f5737/packages/%40glimmer/compiler/lib/javascript-compiler.ts#L269-L271

And add some tests in glimmer-vm for this case.

chancancode commented 5 years ago

https://github.com/emberjs/rfcs/pull/435

rwjblue commented 5 years ago

This is done, and enabled by default in https://github.com/emberjs/ember.js/pull/17901