emberjs / ember.js

Ember.js - A JavaScript framework for creating ambitious web applications
https://emberjs.com
MIT License
22.47k stars 4.21k forks source link

[Bug] destroyables.isDestroying is not a function on canary #19304

Closed mydea closed 3 years ago

mydea commented 3 years ago

🐞 Describe the Bug

In my addon tests, I get the error:

component.js:192 Uncaught TypeError: (0 , _destroyables.isDestroying) is not a function
    at CognitoLoginForm.get isDestroying [as isDestroying] (component.js:192)
    at Class._performShared (-task-property.js:396)
    at Class.perform (-task-property.js:372)
    at -helpers.js:25
    at Backburner._join (backburner.js:995)
    at Backburner.join (backburner.js:760)
    at join (index.js:168)
    at CognitoLoginForm.<anonymous> (index.js:263)
    at index.js:5721
    at instrument (index.js:142)

When running my tests with ember-canary.

πŸ”¬ Minimal Reproduction

You can see the error here: https://github.com/fabscale/ember-cognito-identity/runs/1529670638?check_suite_focus=true

πŸ˜• Actual Behavior

I get an error on canary for code that otherwise works.

πŸ€” Expected Behavior

Code should continue to work on Canary.

🌍 Environment

βž• Additional Context

Originally filed here: https://github.com/machty/ember-concurrency/issues/390#issuecomment-742596351

rwjblue commented 3 years ago

I believe that we have addressed this. @mydea would you mind confirming?

mydea commented 3 years ago

Yes, seems to be working now - thank you!