[Bug] Reactivity breaks with getter chains, dependentKeyCompat and classic computeds - Githubissues

emberjs / ember.js

Ember.js - A JavaScript framework for creating ambitious web applications

https://emberjs.com

MIT License

22.47k stars 4.21k forks source link

[Bug] Reactivity breaks with getter chains, dependentKeyCompat and classic computeds #19556

Open lvegerano opened 3 years ago

lvegerano commented 3 years ago

🐞 Describe the Bug

Classic computed chains do not get properly notified when queryParams are present in a chain with a getter using @dependentKeyCompat

🔬 Minimal Reproduction

https://github.com/lvegerano/computed-mixin-compat

😕 Actual Behavior

Computed in the chain do not recompute

🤔 Expected Behavior

Computed in the chain recompute

🌍 Environment

Ember: - 3.16 - 3.26
Node.js/npm: - 14.16.0 / 6.14.11
OS: - MacOS Big Sur
Browser: - Chrome (90)

➕ Additional Context

I did not test 3.15 but this is working on 3.14

sandstrom commented 1 year ago

I'm doing some issue gardening 🌱🌿 🌷 and came upon this issue. Since it's quite old I just wanted to ask if this is still relevant? If it isn't, maybe we can close this issue?

By closing some old issues we reduce the list of open issues to a more manageable set.