search

emberjs / ember.js

Ember.js - A JavaScript framework for creating ambitious web applications
https://emberjs.com
MIT License
22.46k stars 4.21k forks source link

Deprecation Cleanup for 4.0 #19617

Closed kategengler closed 2 years ago

kategengler commented 3 years ago

PLEASE FLAG REMOVAL/CLEANUP PRs WITH [CLEANUP beta] IN THE PR TITLE.

The following are the deprecations in ember.js that are until 4.0 or earlier. Each item includes the id of the deprecation in backticks. Searching for this id in the source will find the invocations of that deprecation.

Remaining

VM Deprecations

🔒 Built-in Components

All should be :lock: in https://github.com/emberjs/ember.js/pull/19806

Completed

sandstrom commented 3 years ago

What do you think about deprecating Auto Location, is that something you'd like to get in before 4.0?

https://github.com/emberjs/ember.js/pull/19510

It's a fairly low-impact deprecation, in that the change required is a one-line change in the config. More details in that PR and the associated RFC.

But there is also no real rush, deprecating it doesn't "unlock" any new functionality, so could also wait until after 4.0 with merging it.

kategengler commented 3 years ago

@sandstrom This is a list of already deprecated APIs that need to be removed for 4.0. At this point, the master branch is already 4.0, and so no newly added deprecations will make it into 3.x.

nlfurniss commented 3 years ago

IE11 was removed in #19558

snewcomer commented 3 years ago

I can take this one since I did the original PR!

Implicit Injections implicit-injections

snewcomer commented 2 years ago

I understand we are all busy. It is commendable even finding time to track issues, review and contribute code in our spare time. But is there any urgency to get this issue across the line in the coming weeks or is there an often talked about timeline not publicized? I have a few PRs open in glimmer that need review and would be happy to help with any remaining ones (once this tracking checkboxes are updated with where we are at).

kategengler commented 2 years ago

There's definitely some urgency. 4.0 is the next release and ideally we would have gotten this all done before it even branched to beta.

Participation definitely drops over the summer and a few have commented that in the future we should avoid summer for major release pushes. We probably need to find a way to not have time-bound work for major releases.

nlfurniss commented 2 years ago

Both Component manager capabilities prior to 3.13 and Modifier manager capabilities prior to 3.22 are covered by https://github.com/emberjs/ember.js/pull/19762

xg-wang commented 2 years ago

deprecate-router-events is covered by https://github.com/emberjs/ember.js/pull/19749 and ready for review

kategengler commented 2 years ago

This is done! Thank you to everybody who participated in deprecation removal <3