[Documentation] Missing docs for several methods in @ember/helper

[ef4]

The docs for the @ember/helper module are missing several exports that are public API of that module:

• array
• concat
• fn
• get
• hash

They appear instead in Ember.Templates.helpers.

As we're rolling out handlebars strict mode it becomes important to distinguish between the built-in template keywords like yield and the importable helpers like fn.

[SOUMOJIT-CHAKRABORTY]

Hey! @ef4 I want to help on this, can you give me some more details? I am new to opensource.

[ef4]

Hi, I think a good way to start with this would be to join the ember discord and ask in the #dev-ember-learning channel. I don't personally know if the learning team already has a plan for how they would like to do this.

[SOUMOJIT-CHAKRABORTY]

Okay, Thank you for your guidance.

[jenweber]

@SOUMOJIT-CHAKRABORTY thanks for volunteering to help! Here's what I think might need to be done:

• Find where the docs are for invokeHelper. Search this ember.js repository. Our docs exist as code comments.
• Find where the docs are for the template helpers Ed mentioned

Next up is to see if changing the for in the missing method to match the for used by invokeHelper is all that is needed. The @for controls where a code comment shows up in the app.

// before
@for Ember.Templates.helpers

// after
@for @ember/helper

Then run the yuidocs build: yarn docs

And inspect the output files to see if the methods you changed show up somewhere in the json. Compare with invokeHelper.

Running the API docs app locally is a little tricky - you need to turn the docs files into JSONAPI following this guide: https://github.com/ember-learn/ember-jsonapi-docs#quickstart

Then in https://github.com/ember-learn/ember-api-docs run start:local. Make sure you are on Node 14 when you npm install, otherwise the app build will fail.

[SOUMOJIT-CHAKRABORTY]

Okay @jenweber , that's a great help🙂

[Blueclaus13]

is someone working on this issue still?

[RyanMuzzey]

Can this one be closed now that #20408 has been merged?

[MichalBryxi]

I think this is still an issue:

• Class Ember.Templates.helpers @4.5 does mention concat
• Class Ember.Templates.helpers @5.4 does not mention concat

The #20408 talks about moving the helpers around, so maybe they are not supposed to be found on the same spot? Which is fair enough, but then I can't see them in the search either:

• @4.5 does find concat:

• @5.4 does not find concat:

Seems like concat is now defined in glimmer/lib/helpers/concat.ts but the 5.4 guides only mention following from @glimmer: