search

emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
283 stars 873 forks source link

Tell user to (and how to) remove ember-welcome-page addon #2164

Open Gaurav0 opened 6 years ago

Gaurav0 commented 6 years ago

https://guides.emberjs.com/v2.18.0/tutorial/ember-cli/#toc_the-development-server

talks about removing the welcome page component. We should to tell the user to (and how to) remove the ember-welcome-page addon as well.

locks commented 6 years ago

@Gaurav0 the welcome page itself contains instructions how to do it, is that not enough?

locks commented 6 years ago

We also instruct people on how to remove the component from the template. The addon will be inert if the component is not used, so you're not getting things you don't need in the build.

dopin commented 6 years ago

I want it be written too. For translation purpose. Or should the welcome addon be i18n-ed?

Gaurav0 commented 6 years ago

@locks Am I blind? I don't see any mention of the addon here: https://github.com/ember-cli/ember-welcome-page/blob/master/addon/templates/components/welcome-page.hbs

locks commented 6 years ago

Ah, we updated the message when we made the addon not include its assets for production builds.