search

emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
283 stars 873 forks source link

the old guides are not hosted, breaking tons of pages #2211

Open DavidIValencia opened 6 years ago

DavidIValencia commented 6 years ago

please link to the guides for older versions of ember, or at least do something besides providing a 404 for everything that isn't currently online

locks commented 6 years ago

I am not sure what you are referring to @DavidIValencia, can you provide some examples?

DavidIValencia commented 6 years ago

Absolutely,

https://guides.emberjs.com/v1.10.0/components/the-component-lifecycle/ ^^ coming from the select on this page https://guides.emberjs.com/v2.11.0/components/the-component-lifecycle/

This is the first one off the top of my head, but they definitely exist with some regularity on the site. I am on an old version in production for my company, so it's a real roadblock when the guides are not easily accessible.

jenweber commented 6 years ago

Hi David, thanks for sharing some details. The guides content has evolved across the years, so some pages that exist for recent versions (like "component lifecycle") simply did not exist in older versions of the guides. Likewise, some pages you'll find in older versions are not present later down the road.

The search bar results are versioned, so I recommend choosing 1.10 from the dropdown and using internal search. If you come into the site from Google, view certain topics, and then switch versions, that's when you're more likely to hit 404s.

Hopefully that helps explain what you're experiencing - I'm going to close this, but please let us know if you spot anything else that seems off or if there are other problems that are not explained by the above.

jenweber commented 6 years ago

Actually, one more clarifying question. Are you saying that you would prefer that you get redirected to the home page of 1.10 instead of a 404, for example? @DavidIValencia

DavidIValencia commented 6 years ago

Hi Jen,

Yeah, that's what I was referring to more so than some sort of backfill of the old guides. I find it pretty jarring and not that helpful to be redirected to a 404 from a select that gives me the option of viewing the 1.10 version of the guides. A message and a redirect to the 1.10 guides seems like a good in between to me, something like "this part of the guides does not clearly exist in the old version of ember" would cut down on confusion quite a bit.

I remember when I was first learning, I would look up things like closure actions and think they existed in the older versions of ember because I would get a 404 instead of an explanation that that's not a feature in ember 1.10. I also use google instead of the internal search to look through the docs (which I'm realizing now is probably not as good), but that's how you can conceivably get to a lot of features without realizing that they don't exist in older versions. Because like, while there is no clear section on the 1.10 guides for the hooks apparently, they certainly exist and I hook into them which makes the 404 really misleading.

Appreciate the time, have a wonderful Friday and rest of your weekend!