search

emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
283 stars 873 forks source link

Update testing-models.md #2251

Closed denzo closed 6 years ago

sivakumar-kailasam commented 6 years ago

Thanks for the PR @denzo, if you could change the URL to current we could merge this

denzo commented 6 years ago

@sivakumar-kailasam done 👌

jenweber commented 6 years ago

Hey @denzo sorry to ask for you to edit this again, but links within the guides should be relative, so that when someone follows them in the future, they don't end up looking at docs for a newer version than what they were viewing. I think this was originally hardcoded at a specific version by mistake.

@sivakumar-kailasam we should only really be using release and current urls for linking to the API docs.

Here's an example of a relative link:

[some example](../ember-data#toc_updating-the-model-hook)
denzo commented 6 years ago

@jenweber great idea. Done 👌

jenweber commented 6 years ago

Merged, thanks @denzo for the quick turnaround and the help!