search

emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
283 stars 873 forks source link

Update model-hook.md #2269

Closed algo74 closed 6 years ago

algo74 commented 6 years ago

Test fails if
assert.equal(this.element.querySelectorAll('.results .listing').length, 3, 'should display 3 listings'); because listings are not in an element with class "results"

toddjordan commented 6 years ago

according to the example set up in the super rentals repo listing is in results: image

algo74 commented 6 years ago

<ul class="results"> is added in https://guides.emberjs.com/v3.0.0/tutorial/autocomplete-component/ image the code in https://guides.emberjs.com/v3.0.0/tutorial/model-hook/ doesn't have it yet, but the test is already there.

toddjordan commented 6 years ago

yep you're right. good catch.