search

emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
283 stars 874 forks source link

update brace expansion example #2294

Closed sbatson5 closed 6 years ago

sbatson5 commented 6 years ago

What's in this PR?

Fixes https://github.com/emberjs/guides/issues/2291

This updates the example on brace expansion on dependent keys of computed properties. The existing example used keys on the same object as the CP but in my experience, this has been considered bad practice. This update also shortens this section (which never hurts :P )

locks commented 6 years ago

Thanks for the tweak :)

acorncom commented 6 years ago

Nice work @sbatson5, you just passed Tom 😀