search

emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
282 stars 873 forks source link

Remove references to sync queue #2295

Closed jonnii closed 6 years ago

jonnii commented 6 years ago

The sync queue is deprecated in Ember 3.0.

jonnii commented 6 years ago

@rwjblue there's an animation on that page too, I'm not sure where the code lives, I think it was written by machty a long time ago. Any ideas? I can update that too to remove sync from there if needed.

acorncom commented 6 years ago

@jonnii It looks like it's an iframe that loads code up from here (https://s3.amazonaws.com/emberjs.com/run-loop-guide/index.html). Good catch there.

Looks like that's an Ember AppKit app that just does that one thing. If we change the referenced app though we'll change the app for all previous versions of the guides ...

We may want to temporarily copy that into the guides here and then revisit this after we've launched our new guides viewer ... /cc @mansona

jonnii commented 6 years ago

@machty am I right in thinking that this is one of your creations?

machty commented 6 years ago

@jonnii yes, but it was forked and prettified; I believe this is the latest version https://github.com/olivia/ember-run-loop-visual/tree/ui-prettification (4-5 years ago!?!). Who's up for modifying and rebuilding an old ass ember app :)

jonnii commented 6 years ago

@machty I'd be up for the challenge. let me take a look.

jenweber commented 6 years ago

Merged. Thanks @jonnii for reporting this and fixing it!

Deprecation is here https://github.com/emberjs/ember.js/pull/16132