search

emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
282 stars 873 forks source link

Add "async" before test function #2299

Closed khall closed 6 years ago

khall commented 6 years ago

The "async" keyword isn't included in the initial adding of the new test function, which causes a "await is a reserved word" error later when the tests are run, since "await" is being used without "async".

locks commented 6 years ago

It seems slightly funky that an empty test is already marked as async. Hm, can we not add it when we add the await? We could even mention it in the prose.

khall commented 6 years ago

I can buy that, updated.

toddjordan commented 6 years ago

If we are gonna do this we need to remove the async from where the test is mentioned earlier on line 354.

sivakumar-kailasam commented 6 years ago

Thanks for taking the time to contribute to this project. We’re in the process of switching from middleman to an ember app to make it easy for contribution.

We’re closing issue since its been open for too long without progress / it needs more discussion which is probably better had via a new PR in the new app. (sorry about that)

If this PR has changes to the content of guides please raise a PR to https://github.com/ember-learn/guides-source. If the change is to the guides viewer (i.e., the app) then please raise a PR in https://github.com/ember-learn/guides-app/. The READMEs and contributing.md guidelines of those projects will familiarize you with the new process. Let us know if you have any questions!

PS: this is a standard msg we're using across such PRs