emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
283 stars 873 forks source link

Make it clearer where actions can be passed & used #2306

Open jenweber opened 6 years ago

jenweber commented 6 years ago

This page in the guides talks about actions, but doesn't cover some major gotchas around where actions should be put and where they can be passed.

Examples:

This should be explained somehow.

sbatson5 commented 6 years ago

Hi @jenweber 👋 . I wouldn't mind taking a stab at this. There is a lot to unpack when it comes to actions, however. Would it make sense to split some of this up? For instance, perhaps moving some controller specific pieces to the controllers section? There should also be some room for explaining what the action helper is doing for us (i.e. setting the context of the function). It just feels like it's a bit bigger than just the Templates section 🤔

jenweber commented 6 years ago

@sbatson I agree that it’s a bigger issue than one section. I recommend separate PRs so that changes are easier to review. But you can drop some ideas here in this issue for brainstorming