emberjs / guides

This repository is DEPRECATED!

https://github.com/ember-learn/guides-source

Other

283 stars 873 forks source link

Draft for promises #2317

Closed karan-pathak closed 6 years ago

karan-pathak commented 6 years ago

2264

jenweber commented 6 years ago

Hi @karan-pathak ! This is awesome 😄 I see a few typos and small grammar things - is it ok if I add a commit to your PR, or would you rather that I send them to you and you can make the changes?

karan-pathak commented 6 years ago

Hi @jenweber, Thanks for reviewing it! please feel free to make changes to this PR, and if you want me to make the changes then just let me know :)

jenweber commented 6 years ago

@karan-pathak take a look and let me know what you think of my edits!

After looking at this more closely, I think it needs 2 more points:

a sentence or two about how variables modified inside a promise will be undefined for non-Promise-wrapped code (I don't know how to say this better. Does that make any sense to you?)
A closing statement

I am also going to ping @locks and/or @jaredgalanis for review. Promises are hard so some more feedback would be good.

karan-pathak commented 6 years ago

@jenweber, great edits! The extra points that you suggested seem valid. I'll add them to this PR.

Also, more feedback is always welcome :)

toddjordan commented 6 years ago

Thanks for contributing @karan-pathak !