emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
283 stars 874 forks source link

Set headers in init() so people following the guides don't get eslint errors #2322

Closed sdhull closed 6 years ago

sdhull commented 6 years ago

As suggested on the #-team-learning slack channel, this example has been updated so it won't produce eslint errors for people who copy it directly out of the guide.

I added a note in parentheses explaining why, which I was kind of on the fence about including. Happy to update this as the wise learning team sees fit, lmk.

jenweber commented 6 years ago

@sdhull Can you change this to us this.set() instead of just this.headers? After that, it looks good to go.

I err on the side of overexplaining for new people so I think the side note is good to include.

jenweber commented 6 years ago

P.S. thanks for working on this!

sdhull commented 6 years ago

Always looking for ways I can help out 👍 😄

sdhull commented 6 years ago

✅ done

jenweber commented 6 years ago

Super, thank you! So fast 😁 Congrats on your first Guides PR. Merged.