search

emberjs / guides

This repository is DEPRECATED!
https://github.com/ember-learn/guides-source
Other
283 stars 874 forks source link

updated relationships.md | ES6 syntax #2333

Closed hellorahulsingh closed 6 years ago

hellorahulsingh commented 6 years ago

Modified docs according to ES6+ standards.

jenweber commented 6 years ago

Hi @rahulsingh-js, thanks for pitching in! However we are moving the guides over to a new repository very shortly, which means that significant changes to content should be PR'd there. Please see the README for more details. Sorry for the inconvenience. I also recommend opening an issue before doing too much coding, so that we can coordinate a list of places that need to be changed, as well as get team consensus on the switch. Thank you!

hellorahulsingh commented 6 years ago

Hi Jen,

By the time i received your email, i had already submitted my change request.. I am eagerly waiting for the new docs. If possible would you be able to share me the access to new document repository link as i could help you guys in maintaining a well structured docs. I have been working on emberjs from many years. I feel that we are slightly running behing others, even though others are following the same footsteps of ember.

Will wait for you reply.

[image: Mailtrack] https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality4& Sender notified by Mailtrack https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality4&

On 5 May 2018 at 09:26, Jen Weber notifications@github.com wrote:

Hi @rahulsingh-js https://github.com/rahulsingh-js, thanks for pitching in! However we are moving the guides over to a new repository very shortly, which means that significant changes to content should be PR'd there. Please see the README for more details. Sorry for the inconvenience. I also recommend opening an issue before doing too much coding, so that we can coordinate a list of places that need to be changed, as well as get team consensus on the switch. Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/emberjs/guides/pull/2333#issuecomment-386776905, or mute the thread https://github.com/notifications/unsubscribe-auth/ARY59O2q4H-ti9HThw7url5T4uKaMcGBks5tvSL1gaJpZM4TzeyV .

-- Thanks & Regards

*Rahul Singh, Enthusiastic JavaScript Developer *, Gurgaon, India Tel: +91-81-30-319862 Skype: contact.rahul1991 contact.rahul1991@gmail.com | github.com/rahulsingh-js/

jenweber commented 6 years ago

Awesome! Here are the links:

As I mentioned in the other comment, I'd like to get an entry into the JavaScript Primer before we change over a bunch of things into arrow functions. I do agree we need to do the conversion though.

hellorahulsingh commented 6 years ago

Thanks for sharing

On Wed, May 9, 2018, 9:36 AM Jen Weber notifications@github.com wrote:

Awesome! Here are the links:

As I mentioned in the other comment, I'd like to get an entry into the JavaScript Primer before we change over a bunch of things into arrow functions. I do agree we need to do the conversion though.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/emberjs/guides/pull/2333#issuecomment-387613927, or mute the thread https://github.com/notifications/unsubscribe-auth/ARY59GVnfzRZfMEVtlW4lX8Z8aqKXXB6ks5twmsygaJpZM4TzeyV .

sivakumar-kailasam commented 6 years ago

Closing based on @jenweber's comments