search

emberjs / list-view

An incremental rendering list view for Ember.js
MIT License
465 stars 116 forks source link

1.9 issues #181

Closed jasonmit closed 9 years ago

jasonmit commented 9 years ago

The only remaining issue is if you have a yield block, the template renders empty.

Working Example: http://jsbin.com/qurutejeja/1/edit?html,js,output

Not Working:

{{#ember-list content=this height=500 rowHeight=30}}
   foo
{{/ember-list}}

https://github.com/emberjs/list-view/commit/83d006f6decf46d3aa182fc369362951a6a872c9 will work with 1.9 and 1.8.x

This should be finished tomorrow.

/cc @stefanpenner

mmun commented 9 years ago

Awesome :+1:

stefanpenner commented 9 years ago

@jasonmit awesome work!

jasonmit commented 9 years ago

https://github.com/emberjs/ember.js/commit/2a747379d06ce7a4d975349c81a0abd8e5d39a0e is what ended up breaking list-view on 1.9. I should have this fixed shortly..

Custom build of 1.9 with that commit reverted http://jsbin.com/sivaxidade/1/edit?html,js,output

rwjblue commented 9 years ago

That change came from https://github.com/emberjs/ember.js/pull/9716. Extending to create a new view for every {{each}} is very costly.

Why does this change break list-view?

jasonmit commented 9 years ago

@rwjblue I just know this line breaks list-view: https://github.com/emberjs/ember.js/commit/2a747379d06ce7a4d975349c81a0abd8e5d39a0e#diff-a0d09bb980f6aac41530e708d6ea31a8R276

I will have some bandwidth today to look deeper into the cause.

Update: should be a simple fix.. we're overriding arrayDidChange on the ContainerView which doesn't take into account _itemViewProps