emberjs / list-view

An incremental rendering list view for Ember.js
MIT License
465 stars 116 forks source link

Updated README.md to use EmberCLI semantics #211

Closed taras closed 9 years ago

taras commented 9 years ago
ebryn commented 9 years ago

Was there a conversation about renaming to "Ember List"?

taras commented 9 years ago

@stefanpenner and I started talking about releasing the addon and we agreed to publish it on NPM as ember-list. Also, I'm using {{ember-list}} helper in the examples since the View will become increasingly less relevant as approach Ember 2.0.

ebryn commented 9 years ago

I'm not really a fan of Ember List, it's too generic sounding. It also supports grids, so list doesn't feel totally right either.

mmun commented 9 years ago

Agree with @ebryn.

taras commented 9 years ago

@ebryn I'm with you. We need something other than ListView but I don't know what. Suggestions?

ebryn commented 9 years ago

I think we can punt on it a bit longer since it's still a View, and when we need to change it for 2.0 come up with a name potentially better than ListComponent :P

taras commented 9 years ago

Sure, what about npm package name?

ebryn commented 9 years ago

ember-list-view seems fine for now and we can always rename it later?

taras commented 9 years ago

Ok, but I still want to remove reference to Ember.ListView because that's misleading. Should I just call it ListView in the README?

ebryn commented 9 years ago

ListView seems good to me

taras commented 9 years ago

Ok, I renamed Ember.ListView to ListView and Ember.VirtualListView to VirtualListView.

stefanpenner commented 9 years ago

most of this looks great, 2 things:

  1. `import ListView from 'list-view/list-view' is kinda crappy
  2. should we bike-shed the name ListView now or later? I think ember-list-view or list-view is good, even if it it does a grid, or variable height grids. As it is common to want to display a list-in many ways.
jonnii commented 9 years ago

@stefanpenner what about ember-masonry (rim-shot).

stefanpenner commented 9 years ago

@stefanpenner what about ember-masonry (rim-shot).

heh, maybe once/if we actually support more packing algorithms. Unfortunately writing them in way that supports memorization, that is incremental + bound data structure friendly in a performant way is tricky. But i hope it happens someday :)

taras commented 9 years ago

`import ListView from 'list-view/list-view' is kinda crappy

Can we do import ListView from 'ember-list-view'?

stefanpenner commented 9 years ago

Can we do import ListView from 'ember-list-view'?

this would be lovely.

jonnii commented 9 years ago

@stefanpenner on a serious note, what about instead of ember-list-view, something like ember-layouts or something like that. I know the plan is to land the packing stuff at some point, and then the name ember-list-view will be just one of the things this does.

taras commented 9 years ago

@stefanpenner I don't know how to do that with EmberCLI. Can you give me a hint and I'll figure it out from there?

I asked @rwjblue about this before and he said: "That's not how ES6 modules work." and then went and did it for Pretender import Pretender from 'pretender' :hushed:

stefanpenner commented 9 years ago

actually its kinda crappy, @joliss had a good idea but we haven't implemented it yet. For now it actually uses the re-exporter. https://github.com/ember-cli/ember-cli/blob/e38e6d8a65b9977ad3f51bbf57336deb77f2fd56/lib/models/addon.js#L472