search

emberjs / list-view

An incremental rendering list view for Ember.js
MIT License
465 stars 116 forks source link

Upgraded to Ember 1.11.0 #219

Closed taras closed 9 years ago

taras commented 9 years ago

Re: #209

tim-evans commented 9 years ago

:heart:

alexdiliberto commented 9 years ago

:+1: Awesome!

jasonmit commented 9 years ago

:+1:

stefanpenner commented 9 years ago

@taras it was fun pairing on this stuff! I'll have time again Sunday for another round

taras commented 9 years ago

@stefanpenner I spent all night yesterday trying to figure out why the remaining tests are failing and I didn't even make scratch. We might need to do it again if we want to get it out of the door in the near future.

stefanpenner commented 9 years ago

Yes. I am unfortunately spoken for until sunday. I may be able to sneak in some time before then. But does sometime Sunday work for you?

taras commented 9 years ago

Yep, let me know on Slack when you want to start.

I did some investigating of the controller issue that we were debugging and it looks like it works correctly when I rebuild the example in dummy app and it work correctly. Either the helper is unreliable or something more sinister is going on :speak_no_evil:

stefanpenner commented 9 years ago

sinister sounds like fun to me

taras commented 9 years ago

I tested this branch against Ember master that includes #10795 and all tests are passing. We're very close to being able to cut our first major releases with EmberCLI compatibility and Ember 1.10 & Ember 1.11.1 compatibility.

slindberg commented 9 years ago

Thanks @taras! :beers:

alexdiliberto commented 9 years ago

@taras :metal: :beer:

pedrokiefer commented 9 years ago

@taras :+1: :beer:

mrinterweb commented 9 years ago

@taras this is fantastic. I believe these issues were blocking my 1.11 upgrade. Thank you :beers: :cocktail:

jasonmit commented 9 years ago

@taras great job in moving this forward :+1: