emberjs / website

Source for emberjs.com
https://emberjs.com
Other
647 stars 1.33k forks source link

Broken Google maps #3749

Open simonihmig opened 5 years ago

simonihmig commented 5 years ago

Current Behavior

Google Map cannot be loaded. See below for a screenshot.

Expected Behavior

Google Maps should load correctly.

Steps to Reproduce

  1. visit https://www.emberjs.com/community/meetups/

Possible Solution

Seems GMaps is loaded without an API key, which does not work anymore: https://developers.google.com/maps/documentation/javascript/error-messages?utm_source=maps_js&utm_medium=degraded&utm_campaign=keyless#api-key-and-billing-errors

Sources

image

kennethlarsen commented 5 years ago

Thanks for posting this @simonihmig!

I think we need to use Leaflet here like it was done in the Super Rentals app: https://github.com/ember-learn/super-rentals/pull/110/files

mansona commented 5 years ago

Howdy folks 👋

I've just implemented leaflet in the new website here https://github.com/ember-learn/ember-website/pull/96/ but I don't know if we need to fix it on the old one before the new one is launched 🤔

@MelSumner any thoughts? do you think we can hold off and just release the new website to fix this?

MinThaMie commented 5 years ago

I think just the API key they recently introduced is missing: https://developers.google.com/maps/documentation/javascript/get-api-key

simonihmig commented 5 years ago

I think just the API key they recently introduced is missing

Yes, but that requires providing billing details, and costs could occur depending on the actual usage volume. So that's probably a blocker for an OSS project without a corporate backer willing to pay that!?

MinThaMie commented 5 years ago

True :( It's sad that they choose to do this...

mansona commented 5 years ago

I wouldn't worry about this issue too much as it is solved on the new website: https://ember-beta-website.netlify.com/community/meetups

I don't feel comfortable closing this issue until the swap-over has actually happened though 🤔

simonihmig commented 5 years ago

@mansona nice!

Had to file an issue though: https://github.com/ember-learn/ember-website/issues/152 🤷‍♂️