Config exports function rather than object

embermap / ember-cli-fastboot-testing

Test your FastBoot-rendered HTML alongside your application's tests.

https://embermap.github.io/ember-cli-fastboot-testing

MIT License

39 stars 18 forks source link

Config exports function rather than object #762

Closed gilest closed 1 year ago

gilest commented 1 year ago

More closely mirrors the config of ember-cli-fastboot itself and helps to avoid confusion.

One minor difference is that the ember-cli-fastboot version provides application environment as the first argument. Not sure this is necessary for a testing library as presumably it will always be 'test'. Open to suggestions though.

Breaking change but this addon is pre 1.0 so could target the next minor.

Should fix #488

runspired commented 1 year ago

Can make it non-breaking by detecting if its a function and deprecating if it is not

gilest commented 1 year ago

Can make it non-breaking by detecting if its a function and deprecating if it is not

Good idea. Wasn't sure how to use deprecate from @ember/debug within a Node runtime so let me know if you have a better suggestion.

SergeAstapov commented 1 year ago

Thank you @gilest and @runspired!