search

embermap / ember-cli-fastboot-testing

Test your FastBoot-rendered HTML alongside your application's tests.
https://embermap.github.io/ember-cli-fastboot-testing
MIT License
39 stars 18 forks source link

Version 0.6.2 peerDependencies: how to use with Ember 3.28? #883

Open Gaurav0 opened 2 weeks ago

Gaurav0 commented 2 weeks ago

@ember/test-helpers@3.x requires ember-source: 4.x | 5.x as a peerDependency, making it unclear how to use version 0.6.2 of this addon with Ember 3.28. I don't see an ember-try configuration. Please clarify.

If 0.6.2 is incompatible with ember-source@3.28 it should probably have been released as 0.7.0

SergeAstapov commented 2 weeks ago

@Gaurav0 thank you for report! Definitely a miss, we should allow @ember/test-helpers@2.x in peerDependencies as we still test 3.28 in CI.

However, issue is not resurfaced in CI as this addon uses yarn which does not complain about such things.

As a follow up, may need to switch to pnpm with strict peer deps config to avoid such issues.